Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 2749553002: Persist EffectiveConnectionType in UKM on navigation start. (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Persist EffectiveConnectionType in UKM on navigation start. This change emits a UKM PageLoad metric for the EffectiveConnectionType observed at navigation start. This change also corrects an issue where we logged some information in OnStart. When OnStart is invoked, we don't yet know if we're observing a page load, so we move all logging to later in the flow, when we know we're observing a page load. BUG=700537 NOTRY=true NOPRESUBMIT=true TBR=tbansal Review-Url: https://codereview.chromium.org/2740403002 Cr-Commit-Position: refs/heads/master@{#456219} (cherry picked from commit 1401b43ed20688607c38be6e012f9310badf3f2d) Review-Url: https://codereview.chromium.org/2749553002 Cr-Commit-Position: refs/branch-heads/3029@{#150} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/829838488f6690b59944b5f83d427f012b316cc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -17 lines) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 6 chunks +48 lines, -13 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 4 chunks +52 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749553002/1
3 years, 9 months ago (2017-03-13 15:34:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 15:39:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/829838488f6690b59944b5f83d42...

Powered by Google App Engine
This is Rietveld 408576698