Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2740403002: Persist EffectiveConnectionType in UKM on navigation start. (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
Reviewers:
tbansal1
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Persist EffectiveConnectionType in UKM on navigation start. This change emits a UKM PageLoad metric for the EffectiveConnectionType observed at navigation start. This change also corrects an issue where we logged some information in OnStart. When OnStart is invoked, we don't yet know if we're observing a page load, so we move all logging to later in the flow, when we know we're observing a page load. BUG=700537 Review-Url: https://codereview.chromium.org/2740403002 Cr-Commit-Position: refs/heads/master@{#456219} Committed: https://chromium.googlesource.com/chromium/src/+/1401b43ed20688607c38be6e012f9310badf3f2d

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : fix ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -17 lines) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 1 2 6 chunks +48 lines, -13 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 4 chunks +52 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
Bryan McQuade
tbansal, PTAL for use of UINQEService, thanks!
3 years, 9 months ago (2017-03-10 22:33:15 UTC) #10
tbansal1
lgtm. Thanks for doing this.
3 years, 9 months ago (2017-03-10 22:47:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740403002/40001
3 years, 9 months ago (2017-03-10 23:49:25 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 23:55:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1401b43ed20688607c38be6e012f...

Powered by Google App Engine
This is Rietveld 408576698