Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2749513009: Revert of Enable FasterLocationReload feature by default (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, Alexei Svitkine (slow)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable FasterLocationReload feature by default (patchset #1 id:1 of https://codereview.chromium.org/2747413002/ ) Reason for revert: This CL seems to break interactive_ui_tests on multiple bots: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/15140 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/44135 Original issue's description: > Enable FasterLocationReload feature by default > > As a third step of experiment-controlled rollouts, enable > FasterLocationReload feature by default for trunk. > > BUG=591245 > > Review-Url: https://codereview.chromium.org/2747413002 > Cr-Commit-Position: refs/heads/master@{#457346} > Committed: https://chromium.googlesource.com/chromium/src/+/bc7bbd667335209110948cd2f07b4e3b7f44b56c TBR=kinuko@chromium.org,toyoshim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591245 Review-Url: https://codereview.chromium.org/2749513009 Cr-Commit-Position: refs/heads/master@{#457358} Committed: https://chromium.googlesource.com/chromium/src/+/2a7d3504083f59f10b9150d58a00a863056750a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
tzik
Created Revert of Enable FasterLocationReload feature by default
3 years, 9 months ago (2017-03-16 05:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749513009/1
3 years, 9 months ago (2017-03-16 05:23:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2a7d3504083f59f10b9150d58a00a863056750a3
3 years, 9 months ago (2017-03-16 05:25:39 UTC) #6
Takashi Toyoshima
3 years, 9 months ago (2017-03-16 06:26:00 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2746293008/ by toyoshim@chromium.org.

The reason for reverting is: The original change seems to be innocent..

Powered by Google App Engine
This is Rietveld 408576698