Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2747413002: Enable FasterLocationReload feature by default (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, Alexei Svitkine (slow)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable FasterLocationReload feature by default As a third step of experiment-controlled rollouts, enable FasterLocationReload feature by default for trunk. BUG=591245 Review-Url: https://codereview.chromium.org/2747413002 Cr-Commit-Position: refs/heads/master@{#457346} Committed: https://chromium.googlesource.com/chromium/src/+/bc7bbd667335209110948cd2f07b4e3b7f44b56c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Takashi Toyoshima
ptal fyi, this is a part of step 3 of Experiment-controlled rollouts that is explained ...
3 years, 9 months ago (2017-03-15 11:13:55 UTC) #7
kinuko
lgtm
3 years, 9 months ago (2017-03-15 11:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747413002/1
3 years, 9 months ago (2017-03-16 03:56:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bc7bbd667335209110948cd2f07b4e3b7f44b56c
3 years, 9 months ago (2017-03-16 04:06:51 UTC) #13
tzik
3 years, 9 months ago (2017-03-16 05:23:28 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2749513009/ by tzik@chromium.org.

The reason for reverting is: This CL seems to break interactive_ui_tests on
multiple bots:

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/15140
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Powered by Google App Engine
This is Rietveld 408576698