Chromium Code Reviews
DescriptionRevert of Add support for flattening in GeometryMapper. (patchset #10 id:170001 of https://codereview.chromium.org/2744743003/ )
Reason for revert:
1 test failed on Windows 7
VisualRectMappingTest.ShouldAccountForPreserve3dNested
:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/109634
Original issue's description:
> Add support for flattening in GeometryMapper.
>
> Previously we assumed all matrices were preserve-3d, except flattening at the end.
> This worked because we never used GeometryMapper in situations that have any 3D.
>
> In adding tests, fixed what seems to be a bug in LayoutBox::mapToVisualRectInAncestor
> space, in which it would skip flattening if either the local style or container
> style was preseve-3d. The correct behavior is just container.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2744743003
> Cr-Commit-Position: refs/heads/master@{#456281}
> Committed: https://chromium.googlesource.com/chromium/src/+/60792c5afb8cb1eb84db0a874c95286e529eb850
TBR=trchen@chromium.org,chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.chromium.org/2749493003
Cr-Commit-Position: refs/heads/master@{#456347}
Committed: https://chromium.googlesource.com/chromium/src/+/cbda4b6569e36fa05fcb2fa678af03b424fd3cc0
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|