[Devtools] Add stacktrace for Page.frameAttached event

[Devtools] Add stacktrace for Page.frameAttached event

This patch adds possible stacktrace for when a frame is attached to a
page for devtools. This will later be useful to know who/what created an
iframe on a page.

R=dgozman,caseq
BUG=702820
Review-Url: https://codereview.chromium.org/2749383005
Cr-Commit-Position: refs/heads/master@{#458815}
Committed: https://chromium.googlesource.com/chromium/src/+/ddb562bb7707d2d91253156c0c7efc04cffce6f5

[allada, 2017-03-17 22:49:22]

PTL - test to come.

[caseq, 2017-03-18 00:43:59]

So where would this be surfaced?

[allada, 2017-03-18 01:12:34]

On 2017/03/18 00:43:59, caseq wrote:
> So where would this be surfaced?

It will be surfaced for execution context. I will use the executionContext's
frame
to lookup the stacktrace of the creator which will allow me to lookup the script
that created the frame that will give me the originator url which I will then
use
to lookup the associated "product" and show that in the executionContext.

[dgozman, 2017-03-20 17:46:04]

This needs a test.
Also take a look at network-document-initiator.html and check whether it works
in that case as well.

[dgozman, 2017-03-20 17:53:37]

Sorry, missed the test! Looks good, but let's double check for the following
cases:

<iframe src> in html, not in javascript;
<iframe src> in html of child frame, which was created in javascript.

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html
(right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html:60:
InspectorTest.log("    url : " + (showUrl ? frame.url : "<url not shown>"));
Why not show the url?

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:548: { "name":
"stack", "$ref": "Runtime.StackTrace", "optional": true, "description":
"JavaScript stack trace of when frame was attached, set for Script only.",
"experimental": true }
What is "set for Script only"?

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:484:
constructor(model, parentFrame, frameId, payload, callFrames) {
creationStackTrace

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:498:
this._constructionCallFrames = callFrames;
_creationStackTrace

[allada, 2017-03-21 00:19:20]

PTaL

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html
(right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html:60:
InspectorTest.log("    url : " + (showUrl ? frame.url : "<url not shown>"));
On 2017/03/20 17:53:37, dgozman wrote:
> Why not show the url?

url may be a file location, which can change from computer to computer based on
where chromium tests are.

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:548: { "name":
"stack", "$ref": "Runtime.StackTrace", "optional": true, "description":
"JavaScript stack trace of when frame was attached, set for Script only.",
"experimental": true }
On 2017/03/20 17:53:37, dgozman wrote:
> What is "set for Script only"?

I meant "only available if came from script", ie: not sent if from static html.

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:484:
constructor(model, parentFrame, frameId, payload, callFrames) {
On 2017/03/20 17:53:37, dgozman wrote:
> creationStackTrace

Done.

https://codereview.chromium.org/2749383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:498:
this._constructionCallFrames = callFrames;
On 2017/03/20 17:53:37, dgozman wrote:
> _creationStackTrace

Done.

[dgozman, 2017-03-21 22:36:15]

lgtm

[allada, 2017-03-22 01:40:50]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:43:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:43:24]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[allada, 2017-03-22 17:53:43]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-22 17:54:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:37:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490205223771160,
"parent_rev": "a1a7d7c0a8ffdbbc321bf66055cb777e404563b0", "commit_rev":
"ddb562bb7707d2d91253156c0c7efc04cffce6f5"}

[commit-bot: I haz the power, 2017-03-22 18:38:02]

Description was changed from

==========
[Devtools] Add stacktrace for Page.frameAttached event

This patch adds possible stacktrace for when a frame is attached to a
page for devtools. This will later be useful to know who/what created an
iframe on a page.

R=dgozman,caseq
BUG=702820
==========

to

==========
[Devtools] Add stacktrace for Page.frameAttached event

This patch adds possible stacktrace for when a frame is attached to a
page for devtools. This will later be useful to know who/what created an
iframe on a page.

R=dgozman,caseq
BUG=702820

Review-Url: https://codereview.chromium.org/2749383005
Cr-Commit-Position: refs/heads/master@{#458815}
Committed:
https://chromium.googlesource.com/chromium/src/+/ddb562bb7707d2d91253156c0c7e...
==========

[commit-bot: I haz the power, 2017-03-22 18:38:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ddb562bb7707d2d91253156c0c7e...