Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2749383005: [Devtools] Add stacktrace for Page.frameAttached event (Closed)
Patch Set: changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
index ed029a03a510098f54142adea253964c333d648c..6c47a57216bafff54165131f0a11628fc5315a76 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
@@ -670,7 +670,11 @@ void InspectorPageAgent::frameAttachedToParent(LocalFrame* frame) {
Frame* parentFrame = frame->tree().parent();
if (!parentFrame->isLocalFrame())
parentFrame = 0;
- frontend()->frameAttached(frameId(frame), frameId(toLocalFrame(parentFrame)));
+ std::unique_ptr<SourceLocation> location =
+ SourceLocation::captureWithFullStackTrace();
+ frontend()->frameAttached(
+ frameId(frame), frameId(toLocalFrame(parentFrame)),
+ location ? location->buildInspectorObject() : nullptr);
}
void InspectorPageAgent::frameDetachedFromParent(LocalFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698