Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2749203002: Remove ScopedVector from content/. (Closed)

Created:
3 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from content/. base::ScopedVector is deprecated, see bug. BUG=554289 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2749203002 Cr-Commit-Position: refs/heads/master@{#457371} Committed: https://chromium.googlesource.com/chromium/src/+/504f5aa7b3a47722ab1b5e90a02378814b7ac96e

Patch Set 1 #

Patch Set 2 : Remove ScopedVector from content/. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -55 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 2 chunks +10 lines, -13 lines 1 comment Download
M content/child/blob_storage/blob_transport_controller.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 1 4 chunks +10 lines, -7 lines 0 comments Download
M content/public/browser/web_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M content/public/test/test_file_system_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_web_contents_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_web_contents_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 34 (20 generated)
leonhsl(Using Gerrit)
PTAL, Thanks. This is the last CL for content/. And, content/browser/media/android/browser_media_player_manager.cc is changed according from ...
3 years, 9 months ago (2017-03-15 05:20:55 UTC) #8
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-15 15:01:58 UTC) #9
danakj
https://codereview.chromium.org/2749203002/diff/20001/content/browser/media/android/browser_media_player_manager.cc File content/browser/media/android/browser_media_player_manager.cc (right): https://codereview.chromium.org/2749203002/diff/20001/content/browser/media/android/browser_media_player_manager.cc#newcode91 content/browser/media/android/browser_media_player_manager.cc:91: auto media_player_bridge = base::MakeUnique<MediaPlayerBridge>( LGTM :)
3 years, 9 months ago (2017-03-15 15:20:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749203002/20001
3 years, 9 months ago (2017-03-16 03:33:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/386806)
3 years, 9 months ago (2017-03-16 03:40:11 UTC) #14
leonhsl(Using Gerrit)
Let me TBR Tom for OWNER review of content/common/input/input_param_traits_unittest.cc, Thanks!
3 years, 9 months ago (2017-03-16 03:54:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749203002/20001
3 years, 9 months ago (2017-03-16 03:55:06 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/341305)
3 years, 9 months ago (2017-03-16 05:46:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749203002/20001
3 years, 9 months ago (2017-03-16 05:52:37 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/401865)
3 years, 9 months ago (2017-03-16 06:13:01 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749203002/20001
3 years, 9 months ago (2017-03-16 06:33:33 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/408105)
3 years, 9 months ago (2017-03-16 07:23:58 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749203002/20001
3 years, 9 months ago (2017-03-16 07:33:14 UTC) #31
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 08:28:09 UTC) #34
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/504f5aa7b3a47722ab1b5e90a023...

Powered by Google App Engine
This is Rietveld 408576698