Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: content/public/test/mock_render_process_host.cc

Issue 2749203002: Remove ScopedVector from content/. (Closed)
Patch Set: Remove ScopedVector from content/. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/mock_render_process_host.cc
diff --git a/content/public/test/mock_render_process_host.cc b/content/public/test/mock_render_process_host.cc
index 7ea1a745f1be43dc456098ffd11795e67f7c962f..a5eb87852aae85609e0598b81b4d5268410dd174 100644
--- a/content/public/test/mock_render_process_host.cc
+++ b/content/public/test/mock_render_process_host.cc
@@ -10,6 +10,7 @@
#include "base/lazy_instance.h"
#include "base/location.h"
+#include "base/memory/ptr_util.h"
#include "base/process/process_handle.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -377,28 +378,24 @@ MockRenderProcessHostFactory::MockRenderProcessHostFactory() {}
MockRenderProcessHostFactory::~MockRenderProcessHostFactory() {
// Detach this object from MockRenderProcesses to prevent STLDeleteElements()
// from calling MockRenderProcessHostFactory::Remove().
- for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
- it != processes_.end(); ++it) {
- (*it)->SetFactory(NULL);
- }
+ for (const auto& process : processes_)
+ process->SetFactory(nullptr);
}
RenderProcessHost* MockRenderProcessHostFactory::CreateRenderProcessHost(
BrowserContext* browser_context,
SiteInstance* site_instance) const {
- MockRenderProcessHost* host = new MockRenderProcessHost(browser_context);
- if (host) {
- processes_.push_back(host);
- host->SetFactory(this);
- }
- return host;
+ processes_.push_back(
+ base::MakeUnique<MockRenderProcessHost>(browser_context));
+ processes_.back()->SetFactory(this);
+ return processes_.back().get();
}
void MockRenderProcessHostFactory::Remove(MockRenderProcessHost* host) const {
- for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
- it != processes_.end(); ++it) {
- if (*it == host) {
- processes_.weak_erase(it);
+ for (auto it = processes_.begin(); it != processes_.end(); ++it) {
+ if (it->get() == host) {
+ it->release();
+ processes_.erase(it);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698