Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2749023009: Add remoting_user_session to remoting_all (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
Lambros, rkjnsn
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting_user_session to remoting_all remoting_all is supposed to compile all targets under //remoting, but it wasn't compiling remoting_user_session. Review-Url: https://codereview.chromium.org/2749023009 Cr-Commit-Position: refs/heads/master@{#459607} Committed: https://chromium.googlesource.com/chromium/src/+/8b76e0e87c4c2c3c914110eacc3dcfeb423391e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Sergey Ulanov
3 years, 9 months ago (2017-03-17 20:06:49 UTC) #2
Lambros
I wonder if it makes sense to fold :remoting_user_session into :remoting_dev_me2me_host ? LGTM either way, ...
3 years, 9 months ago (2017-03-17 21:28:58 UTC) #3
Sergey Ulanov
On 2017/03/17 21:28:58, Lambros wrote: > I wonder if it makes sense to fold :remoting_user_session ...
3 years, 9 months ago (2017-03-17 21:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749023009/1
3 years, 9 months ago (2017-03-17 21:31:15 UTC) #6
rkjnsn
On 2017/03/17 21:31:15, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-17 21:35:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/386702)
3 years, 9 months ago (2017-03-17 23:17:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749023009/1
3 years, 9 months ago (2017-03-17 23:25:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/403394)
3 years, 9 months ago (2017-03-18 01:26:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749023009/1
3 years, 9 months ago (2017-03-24 23:27:34 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 00:48:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b76e0e87c4c2c3c914110eacc3d...

Powered by Google App Engine
This is Rietveld 408576698