|
|
Created:
3 years, 9 months ago by Sergey Ulanov Modified:
3 years, 9 months ago CC:
chromium-reviews, chromoting-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd remoting_user_session to remoting_all
remoting_all is supposed to compile all targets under //remoting, but
it wasn't compiling remoting_user_session.
Review-Url: https://codereview.chromium.org/2749023009
Cr-Commit-Position: refs/heads/master@{#459607}
Committed: https://chromium.googlesource.com/chromium/src/+/8b76e0e87c4c2c3c914110eacc3dcfeb423391e2
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
sergeyu@chromium.org changed reviewers: + lambroslambrou@chromium.org, rkjnsn@chromium.org
I wonder if it makes sense to fold :remoting_user_session into :remoting_dev_me2me_host ? LGTM either way, see what Erik thinks?
On 2017/03/17 21:28:58, Lambros wrote: > I wonder if it makes sense to fold :remoting_user_session > into :remoting_dev_me2me_host ? > LGTM either way, see what Erik thinks? remoting_dev_me2me_host is usable without remoting_user_session, so I don't think it should depend on it.
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/17 21:31:15, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... LGTM. I agree that remoting_dev_me2me_host doesn't need to depend on it. (Didn't know about remoting_all when I landed the wrapper.)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490398003161670, "parent_rev": "8f2a256cb3ccc0be76c80d2cddde524cd2b5e7cb", "commit_rev": "8b76e0e87c4c2c3c914110eacc3dcfeb423391e2"}
Message was sent while issue was closed.
Description was changed from ========== Add remoting_user_session to remoting_all remoting_all is supposed to compile all targets under //remoting, but it wasn't compiling remoting_user_session. ========== to ========== Add remoting_user_session to remoting_all remoting_all is supposed to compile all targets under //remoting, but it wasn't compiling remoting_user_session. Review-Url: https://codereview.chromium.org/2749023009 Cr-Commit-Position: refs/heads/master@{#459607} Committed: https://chromium.googlesource.com/chromium/src/+/8b76e0e87c4c2c3c914110eacc3d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8b76e0e87c4c2c3c914110eacc3d... |