Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: tools/clang/scripts/update.py

Issue 2749003002: Let the users skip the gold plugin installation
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index 35e57c9023b27f29de05e59d907ddeacc303db32..eff0afbea860256bde5fb4f6a057be5c7eb2facd 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -83,6 +83,8 @@ LLVM_REPO_URL='https://llvm.org/svn/llvm-project'
if 'LLVM_REPO_URL' in os.environ:
LLVM_REPO_URL = os.environ['LLVM_REPO_URL']
+skip_gold_plugin = 'SKIP_GOLD_PLUGIN' in os.environ
+
# Bump after VC updates.
DIA_DLL = {
'2013': 'msdia120.dll',
@@ -398,7 +400,7 @@ def UpdateClang(args):
print 'Updating Clang to %s...' % PACKAGE_VERSION
# Required for LTO, which is used when is_official_build = true.
- need_gold_plugin = sys.platform.startswith('linux')
+ need_gold_plugin = sys.platform.startswith('linux') and not skip_gold_plugin
if ReadStampFile() == PACKAGE_VERSION and not args.force_local_build:
print 'Clang is already up to date.'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698