Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2748983003: [css-grid] Fix crash removing positioned grid item (Closed)

Created:
3 years, 6 months ago by Manuel Rego
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix crash removing positioned grid item When we add or remove a positioned item we don't need to mark the grid as dirty, because positioned items do not affect the layout of the grid at all. This was causing a crash when a positioned item was removed after a layout. As after the positioned item was removed, the method LayoutGrid::layoutBlock() was not called, so when the grid was repainted we got a crash. BUG=700383 TEST=fast/css-grid-layout/grid-crash-remove-positioned-item.html Review-Url: https://codereview.chromium.org/2748983003 Cr-Commit-Position: refs/heads/master@{#457061} Committed: https://chromium.googlesource.com/chromium/src/+/eb7634d5a91a495af9495164ffb2e5f1f91f7e09

Patch Set 1 #

Total comments: 10

Patch Set 2 : Early return, improved test and more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Manuel Rego
3 years, 6 months ago (2017-03-15 09:05:05 UTC) #2
jfernandez
lgtm https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt (right): https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt#newcode5 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt:5: item Do we really need the "item" text ...
3 years, 6 months ago (2017-03-15 09:26:36 UTC) #3
svillar
lgtm too https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html (right): https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html#newcode14 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html:14: document.getElementById("grid").removeChild(document.getElementById("abspositem")); Don't we need a test for ...
3 years, 6 months ago (2017-03-15 10:03:54 UTC) #4
Manuel Rego
Thanks for the quick reviews! https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt (right): https://codereview.chromium.org/2748983003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt#newcode5 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt:5: item On 2017/03/15 09:26:36, ...
3 years, 6 months ago (2017-03-15 10:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748983003/20001
3 years, 6 months ago (2017-03-15 10:59:55 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-03-15 12:46:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb7634d5a91a495af9495164ffb2...

Powered by Google App Engine
This is Rietveld 408576698