third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html - Issue 2748983003: [css-grid] Fix crash removing positioned grid item

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html

Issue 2748983003: [css-grid] Fix crash removing positioned grid item (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.dumpAsText();

	5 </script>

	6 <p>crbug.com/700383 - [css-grid] Grid layouts go mostly blank</p>

	7 <p>This test has PASSED if it does not CRASH on debug.</p>

	8 <div id="grid" style="display: grid;">

	9 <div>item</div>

	10 <div id="abspositem" style="position: absolute;"></div>

	11 </div>

	12 <script>

	13 document.body.offsetLeft;

	14 document.getElementById("grid").removeChild(document.getElementById("absposite m"));
	svillar 2017/03/15 10:03:54 Don't we need a test for the case of adding an abs Don't we need a test for the case of adding an abspos item? Manuel Rego 2017/03/15 10:59:26 Actually that part was not crashing before, but as Show quoted text On 2017/03/15 10:03:54, svillar wrote: > Don't we need a test for the case of adding an abspos item? Actually that part was not crashing before, but as I'm modifying the code, I'll add and remove the child in the test.
	15 </script>

OLD	NEW