cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc::ResourceProvider::Resource::format corresponds to the format as seen
from the compositor and/or GL.

This format might not be the same as the actual buffer format that was
used to create the resource.
For example, a YUV buffer can be used to create a texture/resource with
RGBX internalformat.

The actual format of the buffer is needed to determine if configurations
of quads/resources can be used as overlays. So far we always assumed
the format for overlay candidates was RGBA.

This CL adds a cc::ResourceProvider::Resource::buffer_format that
is the format of the buffer used to create the resource.

Exo code has been changed accordingly to add set the appropriate format.

This CL just adds all the plumbing necessary to bring BufferFormat
all the way to OverlayCandidate, but doesn't change any logic when
creating overlay candidates.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2748903002
Cr-Commit-Position: refs/heads/master@{#456573}
Committed: https://chromium.googlesource.com/chromium/src/+/8409354a9334874b7d00d4f1379a0a2d62c8fbd7

[Daniele Castagna, 2017-03-13 22:48:08]

Description was changed from

==========
cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc::ResourceProvider::Resource::format corresponds to the format as seen
from the compositor and/or GL.

This format might not be the same as the actual buffer format that was
used to create the resource.
For example, a YUV buffer can be used to create a texture/resource with
RGBX internalformat.

The actual format of the buffer is needed to determine if configurations
of quads/resources can be used as overlays. So far we always assumed
the format for overlay candidates was RGBA.

This CL adds a cc::ResourceProvider::Resource::buffer_format that
is the format of the buffer used to create the resource.

Exo code has been changed accordingly to add set the appropriate format.

This CL just adds all the plumbing necessary to bring BufferFormat
all the way to OverlayCandidate, but doesn't change any logic when
creating overlay candidates.

BUG=695296
==========

to

==========
cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc::ResourceProvider::Resource::format corresponds to the format as seen
from the compositor and/or GL.

This format might not be the same as the actual buffer format that was
used to create the resource.
For example, a YUV buffer can be used to create a texture/resource with
RGBX internalformat.

The actual format of the buffer is needed to determine if configurations
of quads/resources can be used as overlays. So far we always assumed
the format for overlay candidates was RGBA.

This CL adds a cc::ResourceProvider::Resource::buffer_format that
is the format of the buffer used to create the resource.

Exo code has been changed accordingly to add set the appropriate format.

This CL just adds all the plumbing necessary to bring BufferFormat
all the way to OverlayCandidate, but doesn't change any logic when
creating overlay candidates.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Daniele Castagna, 2017-03-13 22:48:12]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 22:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-03-13 22:50:47]

dcastagna@chromium.org changed reviewers:
+ dongseong.hwang@chromium.org, reveman@chromium.org

[reveman, 2017-03-13 22:55:37]

As discussed, I think this is reasonable short term but long term it would be
nice to use the actual buffers for hw overlay validation on the gpu process
side.

LGTM

[Daniele Castagna, 2017-03-13 22:56:42]

dcastagna@chromium.org changed reviewers:
+ rsesek@chromium.org

[Daniele Castagna, 2017-03-13 22:56:42]

+rsesek for ownership of cc/ipc/*

[Robert Sesek, 2017-03-13 22:57:27]

lgtm

[Daniele Castagna, 2017-03-13 23:29:02]

The CQ bit was unchecked by dcastagna@chromium.org

[Daniele Castagna, 2017-03-13 23:29:05]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 23:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:47:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Daniele Castagna, 2017-03-14 00:40:16]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 00:40:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 01:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 01:57:44]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2017-03-14 02:02:13]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2017-03-14 02:02:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2748903002/#ps20001
(title: "Always initialize buffer_format.")

[commit-bot: I haz the power, 2017-03-14 02:03:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:11:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489456933245430,
"parent_rev": "316b06f1c28889c56226351535b3ee202d4da517", "commit_rev":
"8409354a9334874b7d00d4f1379a0a2d62c8fbd7"}

[commit-bot: I haz the power, 2017-03-14 02:12:24]

Description was changed from

==========
cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc::ResourceProvider::Resource::format corresponds to the format as seen
from the compositor and/or GL.

This format might not be the same as the actual buffer format that was
used to create the resource.
For example, a YUV buffer can be used to create a texture/resource with
RGBX internalformat.

The actual format of the buffer is needed to determine if configurations
of quads/resources can be used as overlays. So far we always assumed
the format for overlay candidates was RGBA.

This CL adds a cc::ResourceProvider::Resource::buffer_format that
is the format of the buffer used to create the resource.

Exo code has been changed accordingly to add set the appropriate format.

This CL just adds all the plumbing necessary to bring BufferFormat
all the way to OverlayCandidate, but doesn't change any logic when
creating overlay candidates.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add gfx::BufferFormat to cc::ResourceProvider::Resource.

cc::ResourceProvider::Resource::format corresponds to the format as seen
from the compositor and/or GL.

This format might not be the same as the actual buffer format that was
used to create the resource.
For example, a YUV buffer can be used to create a texture/resource with
RGBX internalformat.

The actual format of the buffer is needed to determine if configurations
of quads/resources can be used as overlays. So far we always assumed
the format for overlay candidates was RGBA.

This CL adds a cc::ResourceProvider::Resource::buffer_format that
is the format of the buffer used to create the resource.

Exo code has been changed accordingly to add set the appropriate format.

This CL just adds all the plumbing necessary to bring BufferFormat
all the way to OverlayCandidate, but doesn't change any logic when
creating overlay candidates.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2748903002
Cr-Commit-Position: refs/heads/master@{#456573}
Committed:
https://chromium.googlesource.com/chromium/src/+/8409354a9334874b7d00d4f1379a...
==========

[commit-bot: I haz the power, 2017-03-14 02:12:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8409354a9334874b7d00d4f1379a...