Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2745143003: cc: Make OverlayCandidate use gfx::BufferFormat instead of cc::ResourceFormat. (Closed)

Created:
3 years, 9 months ago by Daniele Castagna
Modified:
3 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make OverlayCandidate use gfx::BufferFormat instead of cc::ResourceFormat. Use gfx::BufferFormat instead of cc::ResourceFormat in OverlayCandidate. With crrev.com/2748903002 gfx::BufferFormat has been added to Resource. OverlayCandidate can now use that gfx::BufferFormat instead of using and hardcoded RGBA Resource format. This patch was pulled from crrev.com/2683763003 patch 1. The original author is dongseong.hwang. BUG=695296, 683347 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2745143003 Cr-Commit-Position: refs/heads/master@{#456785} Committed: https://chromium.googlesource.com/chromium/src/+/8b03b3715b4f951d87890c6ef9f6cbe027f777f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -22 lines) Patch
M cc/output/overlay_candidate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/output/overlay_candidate.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M components/display_compositor/compositor_overlay_candidate_validator_ozone.cc View 2 chunks +1 line, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Daniele Castagna
3 years, 9 months ago (2017-03-14 01:28:20 UTC) #4
reveman
lgtm
3 years, 9 months ago (2017-03-14 01:29:51 UTC) #5
Daniele Castagna
+ccameron for components/display_compositor ownership.
3 years, 9 months ago (2017-03-14 01:31:43 UTC) #10
ccameron
On 2017/03/14 01:31:43, Daniele Castagna wrote: > +ccameron for components/display_compositor ownership. lgtm
3 years, 9 months ago (2017-03-14 19:20:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745143003/1
3 years, 9 months ago (2017-03-14 19:24:17 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 19:30:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b03b3715b4f951d87890c6ef9f6...

Powered by Google App Engine
This is Rietveld 408576698