Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2748823002: Stability file: collect generic activities (Closed)

Created:
3 years, 9 months ago by manzagop (departed)
Modified:
3 years, 9 months ago
Reviewers:
bcwhite
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stability file: collect generic activities Also ensure activity time, address and origin address are always collected. BUG=691595 Review-Url: https://codereview.chromium.org/2748823002 Cr-Commit-Position: refs/heads/master@{#456493} Committed: https://chromium.googlesource.com/chromium/src/+/4c123ff892dc70fc8b14b15ef01cf3bc14a57dae

Patch Set 1 #

Patch Set 2 : Update dump_postmortem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -35 lines) Patch
M components/browser_watcher/dump_postmortem_minidump_main_win.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M components/browser_watcher/postmortem_report_collector_unittest.cc View 5 chunks +14 lines, -3 lines 0 comments Download
M components/browser_watcher/postmortem_report_extractor.cc View 2 chunks +42 lines, -29 lines 0 comments Download
M components/browser_watcher/stability_report.proto View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
manzagop (departed)
Please have a look.
3 years, 9 months ago (2017-03-13 19:32:26 UTC) #3
bcwhite
lgtm
3 years, 9 months ago (2017-03-13 19:56:57 UTC) #7
manzagop (departed)
Thanks!
3 years, 9 months ago (2017-03-13 20:06:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748823002/20001
3 years, 9 months ago (2017-03-13 20:07:04 UTC) #11
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-13 21:18:11 UTC) #14
manzagop (departed)
On 2017/03/13 21:18:11, commit-bot: I haz the power wrote: > Prior attempt to commit was ...
3 years, 9 months ago (2017-03-13 21:22:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748823002/20001
3 years, 9 months ago (2017-03-13 21:23:52 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:31:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c123ff892dc70fc8b14b15ef01c...

Powered by Google App Engine
This is Rietveld 408576698