Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/browser_watcher/stability_report.proto

Issue 2748823002: Stability file: collect generic activities (Closed)
Patch Set: Update dump_postmortem Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/postmortem_report_extractor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/stability_report.proto
diff --git a/components/browser_watcher/stability_report.proto b/components/browser_watcher/stability_report.proto
index 015d4751b9dee57c6451a1f1441c80cb2deec491..18ea17cd8ddd5a487e3a29098dc273012c5e2fd6 100644
--- a/components/browser_watcher/stability_report.proto
+++ b/components/browser_watcher/stability_report.proto
@@ -87,7 +87,7 @@ message TypedValue {
}
// An activity represents information about something of interest on a thread.
-// Next id: 11
+// Next id: 14
message Activity {
enum Type {
UNKNOWN = 0;
@@ -96,6 +96,7 @@ message Activity {
ACT_EVENT_WAIT = 3;
ACT_THREAD_JOIN = 4;
ACT_PROCESS_WAIT = 5;
+ ACT_GENERIC = 6;
}
// Identifies the type of the activity (and specifies which fields are
@@ -105,8 +106,12 @@ message Activity {
// Creation time of the activity.
optional int64 time = 2;
- // The address that is the origin of the activity.
- // Expected for ACT_TASK_*
+ // The address that pushed the activity onto the stack.
+ optional uint64 address = 11;
+
+ // The address that is the origin of the activity. This is useful for things
+ // like tasks that are posted from a completely different thread though most
+ // activities will leave it null.
optional uint64 origin_address = 3;
// The sequence identifier of the posted task.
@@ -125,6 +130,12 @@ message Activity {
// A unique identifier for a process.
optional int64 process_id = 8;
+ // An arbitrary identifier used for association.
+ optional uint32 generic_id = 12;
+
+ // An arbitrary value used for information purposes.
+ optional int32 generic_data = 13;
+
// Tag id 10 is reserved for server side augmentation.
// A key-value store.
« no previous file with comments | « components/browser_watcher/postmortem_report_extractor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698