Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2748803002: Reland of Split LivenessService out from LibCrosService. (Closed)

Created:
3 years, 9 months ago by Khushal
Modified:
3 years, 9 months ago
Reviewers:
teravest, Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Split LivenessService out from LibCrosService. (patchset #1 id:1 of https://codereview.chromium.org/2742343004/ ) Reason for revert: Reverting the revert. Looks like this change is unrelated. https://bugs.chromium.org/p/chromium/issues/detail?id=700823 Original issue's description: > Revert of Split LivenessService out from LibCrosService. (patchset #3 id:40001 of https://codereview.chromium.org/2741803005/ ) > > Reason for revert: > Speculative revert for failing downstream bots: https://bugs.chromium.org/p/chromium/issues/detail?id=700986 > > Original issue's description: > > Split LivenessService out from LibCrosService. > > > > This is part of a larger effort to split LibCrosService into smaller > > services for mus+ash. > > > > I've added a TODO to remove the old service once we've migrated > > clients over to call the new one. > > > > BUG=692246 > > > > Review-Url: https://codereview.chromium.org/2741803005 > > Cr-Commit-Position: refs/heads/master@{#456411} > > Committed: https://chromium.googlesource.com/chromium/src/+/074cfdfc2e36001a72f2e2dfbcd7cc91819221e4 > > TBR=derat@chromium.org,teravest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=692246 > > Review-Url: https://codereview.chromium.org/2742343004 > Cr-Commit-Position: refs/heads/master@{#456422} > Committed: https://chromium.googlesource.com/chromium/src/+/ecf7f3deeb90473ecd3ef116301f0a02637da717 TBR=derat@chromium.org,teravest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692246 Review-Url: https://codereview.chromium.org/2748803002 Cr-Commit-Position: refs/heads/master@{#456424} Committed: https://chromium.googlesource.com/chromium/src/+/b2a374ecdadcd8ebb5f6b9478458725ca25768e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +14 lines, -1 line 0 comments Download
M chromeos/dbus/services/liveness_service_provider.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chromeos/dbus/services/liveness_service_provider.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Khushal
Created Reland of Split LivenessService out from LibCrosService.
3 years, 9 months ago (2017-03-13 18:01:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748803002/1
3 years, 9 months ago (2017-03-13 18:03:07 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:04:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2a374ecdadcd8ebb5f6b9478458...

Powered by Google App Engine
This is Rietveld 408576698