Add static analysis support to Win Clang builds

Add static analysis support to Win Clang builds

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243
Review-Url: https://codereview.chromium.org/2748793004
Cr-Commit-Position: refs/heads/master@{#457566}
Committed: https://chromium.googlesource.com/chromium/src/+/5847e4bdf3b65ccc136bc42ef00d573f2adb50fb

[Kevin M, 2017-03-13 23:56:13]

Description was changed from

==========
WIP clang on Windows
==========

to

==========
This script allows Windows Chrome developers to benefit from Clang static
analysis by setting "use_clang_static_analyzer = true" in their GN build args.
Works with Goma.

Also modified the Clang analysis wrapper script to conditionally pass analysis
command line options in a manner compatible with Windows build's clang-cl.exe.


BUG=687243
==========

[Kevin M, 2017-03-13 23:56:13]

kmarshall@chromium.org changed reviewers:
+ brucedawson@chromium.org, danakj@chromium.org

[danakj, 2017-03-14 15:16:24]

Please format your CL description:
- Separate subject from body with a blank line
- Limit the subject line to 50 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line
- Wrap the body at 72 characters
- Use the body to explain what and why vs. how

From: https://chris.beams.io/posts/git-commit/

[danakj, 2017-03-14 15:22:13]

LGTM % brucedawson

[Kevin M, 2017-03-14 16:48:14]

Description was changed from

==========
This script allows Windows Chrome developers to benefit from Clang static
analysis by setting "use_clang_static_analyzer = true" in their GN build args.
Works with Goma.

Also modified the Clang analysis wrapper script to conditionally pass analysis
command line options in a manner compatible with Windows build's clang-cl.exe.


BUG=687243
==========

to

==========
Add static analysis support for Clang on Windows.

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243
==========

[Kevin M, 2017-03-14 16:50:09]

Done. brucedawson, PTAL

[brucedawson, 2017-03-14 17:46:07]

On 2017/03/14 16:50:09, Kevin M wrote:
> Done. brucedawson, PTAL

The subject line in the CL still has a period. Also the subject line in the CL
now differs from the issue title.

Looking at the changes now...

[Kevin M, 2017-03-14 17:48:46]

Description was changed from

==========
Add static analysis support for Clang on Windows.

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243
==========

to

==========
Add static analysis support to Win Clang builds

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243
==========

[brucedawson, 2017-03-14 17:56:38]

https://codereview.chromium.org/2748793004/diff/140001/build/toolchain/clang_...
File build/toolchain/clang_static_analyzer_wrapper.py (right):

https://codereview.chromium.org/2748793004/diff/140001/build/toolchain/clang_...
build/toolchain/clang_static_analyzer_wrapper.py:53: action='store_true')
I'm not familiar enough with the available options, but would it be obvious to
an expert what happens when cl-mode is not specified? i.e.; is it obvious that
!--cl-mode means Xanalyzer?

In other words, would it be better to have --analyze-mode=[Xanalyzer|Xclang], or
is the current flag sufficient? Just checking.

[Kevin M, 2017-03-14 19:11:04]

https://codereview.chromium.org/2748793004/diff/140001/build/toolchain/clang_...
File build/toolchain/clang_static_analyzer_wrapper.py (right):

https://codereview.chromium.org/2748793004/diff/140001/build/toolchain/clang_...
build/toolchain/clang_static_analyzer_wrapper.py:53: action='store_true')
On 2017/03/14 17:56:38, brucedawson wrote:
> I'm not familiar enough with the available options, but would it be obvious to
> an expert what happens when cl-mode is not specified? i.e.; is it obvious that
> !--cl-mode means Xanalyzer?

My thinking was that the layperson would assume that the omission of an optional
parameter would result in default behavior. That's strictly true in this case,
as -Xanalyzer is the native Clang interface for passing analyzer arguments --
clang_cl.exe is an adapter layer, so in my view it represents an alternate mode.

I can see how the layperson wouldn't care about that technical distinction, so
I'll just expose the two choices as an explicit string option. I think exposing
the detail of the exact arg prefix may be too esoteric, so I'll abstract the
choice as "clang" and "cl" instead.

[Kevin M, 2017-03-14 19:11:14]

The CQ bit was checked by kmarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 19:11:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 20:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:22:14]

Dry run: This issue passed the CQ dry run.

[Kevin M, 2017-03-16 17:25:32]

PTAL

[brucedawson, 2017-03-16 19:34:31]

lgtm

[Kevin M, 2017-03-16 19:48:42]

The CQ bit was checked by kmarshall@chromium.org

[Kevin M, 2017-03-16 19:48:42]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2748793004/#ps200001
(title: "Improve mode arg help text")

[commit-bot: I haz the power, 2017-03-16 19:49:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:39:55]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1489693722302420,
"parent_rev": "65f1ba166c45456df7947ef9a8888cefcee313fa", "commit_rev":
"5847e4bdf3b65ccc136bc42ef00d573f2adb50fb"}

[commit-bot: I haz the power, 2017-03-16 21:40:38]

Description was changed from

==========
Add static analysis support to Win Clang builds

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243
==========

to

==========
Add static analysis support to Win Clang builds

This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.

* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.


BUG=687243

Review-Url: https://codereview.chromium.org/2748793004
Cr-Commit-Position: refs/heads/master@{#457566}
Committed:
https://chromium.googlesource.com/chromium/src/+/5847e4bdf3b65ccc136bc42ef00d...
==========

[commit-bot: I haz the power, 2017-03-16 21:40:39]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/5847e4bdf3b65ccc136bc42ef00d...