Add static analysis support to Win Clang builds

build/toolchain/clang_static_analyzer_wrapper.py

 #!/usr/bin/env python
 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Adds an analysis build step to invocations of the Clang C/C++ compiler.
 
 Usage: clang_static_analyzer_wrapper.py <compiler> [args...]
 """
 
 import argparse
 import fnmatch
 import itertools
 import os
 import sys
 import wrapper_utils
 
 # Flags used to enable analysis for Clang invocations.
 analyzer_enable_flags = [
     '--analyze',
-    '-fdiagnostics-show-option',
 ]
 
 # Flags used to configure the analyzer's behavior.
 analyzer_option_flags = [
+    '-fdiagnostics-show-option',
     '-analyzer-checker=cplusplus',
     '-analyzer-opt-analyze-nested-blocks',
     '-analyzer-eagerly-assume',
     '-analyzer-output=text',
     '-analyzer-config',
     'suppress-c++-stdlib=true',
 
 # List of checkers to execute.
 # The full list of checkers can be found at
 # https://clang-analyzer.llvm.org/available_checks.html.
     '-analyzer-checker=core',
     '-analyzer-checker=unix',
     '-analyzer-checker=deadcode',
 ]
 
 
+# Prepends every element of a list |args| with |token|.
+# e.g. ['-analyzer-foo', '-analyzer-bar'] => ['-Xanalyzer', '-analyzer-foo',
+#                                             '-Xanalyzer', '-analyzer-bar']
+def interleave_args(args, token):
+  return list(sum(zip([token] * len(args), args), ()))
+
+
 def main():
-  args = sys.argv[1:]
-  assert args
+  parser = argparse.ArgumentParser()
+  parser.add_argument('--mode',
+                      choices=['clang', 'cl'],
+                      required=True,
+                      help='Specifies the compiler argument convention to use.')
+  parser.add_argument('args', nargs=argparse.REMAINDER)
+  parsed_args = parser.parse_args()
 
-  # Build the object file and proceed with analysis if it is buildable.
+  prefix = '-Xclang' if parsed_args.mode == 'cl' else '-Xanalyzer'
+  cmd = parsed_args.args + analyzer_enable_flags + \
+        interleave_args(analyzer_option_flags, prefix)
   returncode, stderr = wrapper_utils.CaptureCommandStderr(
-    wrapper_utils.CommandToRun(args))
-  sys.stderr.write(stderr)
-  if returncode != 0:
-    return returncode
-
-  # Now run the analyzer.
-
-  # Interleave 'analyzer_option_flags' flags w/'-Xanalyzer' so that Clang
-  # passes them to the analysis tool.
-  # e.g. ['-analyzer-foo', '-analyzer-bar'] => ['-Xanalyzer', '-analyzer-foo',
-  #                                             '-Xanalyzer', '-analyzer-bar']
-  interleaved_analyzer_flags = list(sum(zip(
-      ['-Xanalyzer'] * len(analyzer_option_flags),
-      analyzer_option_flags), ()))
-  returncode, stderr = wrapper_utils.CaptureCommandStderr(
-      wrapper_utils.CommandToRun(args + analyzer_enable_flags +
-                                 interleaved_analyzer_flags))
+      wrapper_utils.CommandToRun(cmd))
   sys.stderr.write(stderr)
   if returncode != 0:
     sys.stderr.write(
         """WARNING! The Clang static analyzer exited with error code %d.
          Please share the error details in crbug.com/695243 if this looks like
          a new regression.\n""" % (returncode))
 
-  return 0
+  returncode, stderr = wrapper_utils.CaptureCommandStderr(
+    wrapper_utils.CommandToRun(parsed_args.args))
+  sys.stderr.write(stderr)
+
+  return returncode
 
 if __name__ == '__main__':
   sys.exit(main())