Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2748683002: Disable NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore on Android (Closed)

Created:
3 years, 9 months ago by blundell
Modified:
3 years, 9 months ago
Reviewers:
Gleb Lanbin
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore on Android https://codereview.chromium.org/2739683006 introduced a test failure on Android: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62131. I would ordinarily revert the CL but it doesn't revert cleanly as https://codereview.chromium.org/2735703005 landed afterward, and I don't have enough domain expertise to know whether these two patches are related or independent. As a result I'm just disabling the test on Android. This however means that the bug is still present in the tree, so crbug.com/700868 needs to be fixed ASAP. BUG=700868 TBR=glebl Review-Url: https://codereview.chromium.org/2748683002 Cr-Commit-Position: refs/heads/master@{#456361} Committed: https://chromium.googlesource.com/chromium/src/+/2ac5618843f8e7b3044b9931c571d45aaf2915ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
blundell
3 years, 9 months ago (2017-03-13 12:19:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748683002/1
3 years, 9 months ago (2017-03-13 12:19:25 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 13:21:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ac5618843f8e7b3044b9931c571...

Powered by Google App Engine
This is Rietveld 408576698