third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc - Issue 2748683002: Disable NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

Issue 2748683002: Disable NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore on Android (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

index 242428fdbffa9f53f920273935754cbb61b59664..cfabfcc8f2c4bc1d16a60dad88c6d0eb8dd2f3b5 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc

@@ -18,7 +18,13 @@ class NGTextLayoutAlgorithmTest : public NGBaseLayoutAlgorithmTest {};

// Verifies that text can flow correctly around floats that were positioned

// before the inline block.

-TEST_F(NGTextLayoutAlgorithmTest, TextFloatsAroundFloatsBefore) {

+// Failing on Android: crbug.com/700868

+#if OS(ANDROID)

+#define MAYBE_TextFloatsAroundFloatsBefore DISABLED_TextFloatsAroundFloatsBefore

+#else

+#define MAYBE_TextFloatsAroundFloatsBefore TextFloatsAroundFloatsBefore

+#endif

+TEST_F(NGTextLayoutAlgorithmTest, MAYBE_TextFloatsAroundFloatsBefore) {

setBodyInnerHTML(R"HTML(

<!DOCTYPE html>

<style>

« no previous file with comments | « no previous file | no next file » | no next file with comments »