Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2748673003: [Mac] Fullscreen Toolbar Fixes (Closed)

Created:
3 years, 9 months ago by spqchan
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen Toolbar Fixes - Fixed the layout issues with the fullscreen toolbar - Fixed the hiding animation BUG=689115 Review-Url: https://codereview.chromium.org/2738043002 Cr-Commit-Position: refs/heads/master@{#456117} (cherry picked from commit e86cff1a78d3b1f75b454487afee3101d3504519) Review-Url: https://codereview.chromium.org/2748673003 . Cr-Commit-Position: refs/branch-heads/3029@{#155} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
3 years, 9 months ago (2017-03-13 17:23:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5ef80f22ed957850a6d0149a507d9bc9cf5f07d.

Powered by Google App Engine
This is Rietveld 408576698