Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2748563002: Fix another caret paint invalidation issue (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix another caret paint invalidation issue This issue occurred when the caret was blinking to invisible state and at the same time the caret was moved to another place in the same block. Change code to ensure m_visualRectInPreviousLayoutBlock is invalidated. BUG=699044 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2739253002 Cr-Original-Commit-Position: refs/heads/master@{#456275} Review-Url: https://codereview.chromium.org/2748563002 Cr-Commit-Position: refs/branch-heads/3029@{#135} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4f3f496493209a314f968d9d5fdd2bc75982bd68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp View 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748563002/1
3 years, 9 months ago (2017-03-12 05:00:56 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-12 05:03:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f3f496493209a314f968d9d5fdd...

Powered by Google App Engine
This is Rietveld 408576698