Fix another caret paint invalidation issue

Fix another caret paint invalidation issue

This issue occurred when the caret was blinking to invisible state and
at the same time the caret was moved to another place in the same block.

Change code to ensure m_visualRectInPreviousLayoutBlock is invalidated.

BUG=699044
Review-Url: https://codereview.chromium.org/2739253002
Cr-Commit-Position: refs/heads/master@{#456275}
Committed: https://chromium.googlesource.com/chromium/src/+/68ce3db5142fd83af38eb4ae9b5bc701d0555f7b

[Xianzhu, 2017-03-09 23:20:28]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-03-10 05:06:08]

https://codereview.chromium.org/2739253002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp (right):

https://codereview.chromium.org/2739253002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp:218:
m_visualRect == m_visualRectInPreviousLayoutBlock) {
Why is this conditional required? Can't figure this out yet. Add a comment also?

[Xianzhu, 2017-03-10 05:59:05]

I modified the patch which is equivalent to the first version but should be more
readable. Also added comments.

[Xianzhu, 2017-03-10 16:44:19]

On 2017/03/10 05:59:05, Xianzhu wrote:
> I modified the patch which is equivalent to the first version but should be
more
> readable. Also added comments.

I think I found a way to further simplify the class. Will upload a new patch
soon.

[Xianzhu, 2017-03-10 16:47:52]

On 2017/03/10 16:44:19, Xianzhu wrote:
> On 2017/03/10 05:59:05, Xianzhu wrote:
> > I modified the patch which is equivalent to the first version but should be
> more
> > readable. Also added comments.
> 
> I think I found a way to further simplify the class. Will upload a new patch
> soon.

Scratch that. The "new way" won't work. Still Patch Set 2.

[chrishtr, 2017-03-10 23:30:59]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-10 23:31:00]

lgtm

[commit-bot: I haz the power, 2017-03-10 23:31:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-03-11 02:43:31]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-03-11 02:43:34]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:43:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 04:05:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489200214819230,
"parent_rev": "85eb0199323407db76feaa192e0d0a0fd9b24f6f", "commit_rev":
"68ce3db5142fd83af38eb4ae9b5bc701d0555f7b"}

[commit-bot: I haz the power, 2017-03-11 04:06:51]

Description was changed from

==========
Fix another caret paint invalidation issue

This issue occurred when the caret was blinking to invisible state and
at the same time the caret was moved to another place in the same block.

Change code to ensure m_visualRectInPreviousLayoutBlock is invalidated.

BUG=699044
==========

to

==========
Fix another caret paint invalidation issue

This issue occurred when the caret was blinking to invisible state and
at the same time the caret was moved to another place in the same block.

Change code to ensure m_visualRectInPreviousLayoutBlock is invalidated.

BUG=699044

Review-Url: https://codereview.chromium.org/2739253002
Cr-Commit-Position: refs/heads/master@{#456275}
Committed:
https://chromium.googlesource.com/chromium/src/+/68ce3db5142fd83af38eb4ae9b5b...
==========

[commit-bot: I haz the power, 2017-03-11 04:06:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68ce3db5142fd83af38eb4ae9b5b...