Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2748473003: Use exactly 1em marker margin for list-style:inside items (Closed)

Created:
3 years, 9 months ago by Gleb Lanbin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use exactly 1em marker margin for list-style:inside items Fix the interop issue for list-style:inside items. W3C spec http://www.w3.org/TR/css3-lists/#ua-stylesheet recommends 1em margin for markers. Unlike other browsers (verified with Edge and Firefox) Chrome does not follow UA stylesheet recommendation. The fix is temporarily landed in LayoutListMarker.cpp. Default UA CSS should be moved to WebKit/Source/core/css/html.css after crbug.com/457718 is fixed. BUG=644630 Review-Url: https://codereview.chromium.org/2748473003 Cr-Commit-Position: refs/heads/master@{#457059} Committed: https://chromium.googlesource.com/chromium/src/+/f0a3c480bad0bcd9432d2193fba26c230092c986

Patch Set 1 : deliberately failed tests #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -189 lines) Patch
M third_party/WebKit/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/001-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/001-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/004-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/004-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/008-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/008-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/008-vertical-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/008-vertical-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/markers-in-selection-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/lists/markers-in-selection-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/lists/008-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/001-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/001-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/004-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/004-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/008-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/008-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/008-vertical-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/008-vertical-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/markers-in-selection-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/lists/markers-in-selection-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/css/001-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/css/001-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/004-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/004-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/008-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/008-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/008-vertical-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/008-vertical-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/markers-in-selection-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/lists/markers-in-selection-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug30692-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug30692-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/list-marker-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/classification/list_style_position-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/css1/classification/list_style_position-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Gleb Lanbin
3 years, 9 months ago (2017-03-13 21:19:58 UTC) #8
Gleb Lanbin
3 years, 9 months ago (2017-03-14 16:51:04 UTC) #12
Gleb Lanbin
On 2017/03/14 16:51:04, Gleb Lanbin wrote: Christian said that he is not very familiar with ...
3 years, 9 months ago (2017-03-14 16:53:44 UTC) #13
mstensho (USE GERRIT)
lgtm
3 years, 9 months ago (2017-03-15 10:46:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748473003/20001
3 years, 9 months ago (2017-03-15 10:47:11 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:24:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f0a3c480bad0bcd9432d2193fba2...

Powered by Google App Engine
This is Rietveld 408576698