third_party/WebKit/Source/core/layout/LayoutListMarker.cpp - Issue 2748473003: Use exactly 1em marker margin for list-style:inside items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 2748473003: Use exactly 1em marker margin for list-style:inside items (Closed)

Patch Set: rebaseline Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

index c7e5f98625bb2832b136533bfae1c097d7de8ee5..40071880ce8b1af944c71a0c15445e1067cb9def 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

@@ -295,7 +295,6 @@ void LayoutListMarker::updateMargins() {

case ListStyleCategory::Symbol:

marginStart = LayoutUnit(-1);

marginEnd =

- fontMetrics.ascent() - minPreferredLogicalWidth() + 1 +

LayoutUnit(cUAMarkerMarginEm * style()->computedFontSize());

break;

default: