Fix chrome/test/data/safe_browsing/dmg/generate_test_data.sh to not silently fail.

Fix chrome/test/data/safe_browsing/dmg/generate_test_data.sh to not silently fail.

generate_test_data.sh uses `hdiutil create` and `hdiutil convert`. The former
can overwrite an existing output file, but the latter cannot. This led to the
following error:

  hdiutil: convert failed - File exists

But this message was getting swallowed because the script 1) did not do `set -e`
to stop on errors, and 2) redirect all output to /dev/null. This also fixes both
of those issues.

BUG=696529
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2748453002
Cr-Commit-Position: refs/heads/master@{#456141}
Committed: https://chromium.googlesource.com/chromium/src/+/5fe29f761d6791d746bd7e058d6f3d79227cc117

[Robert Sesek, 2017-03-10 18:50:16]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 18:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-10 19:12:50]

lgtm

[commit-bot: I haz the power, 2017-03-10 19:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:49:55]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-03-10 19:50:18]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:50:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:59:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489175418036520, "parent_rev":
"3c309fdbb3787d140f76c1cfc3ef8a994d8d4a4d", "commit_rev":
"5fe29f761d6791d746bd7e058d6f3d79227cc117"}

[commit-bot: I haz the power, 2017-03-10 20:00:05]

Description was changed from

==========
Fix chrome/test/data/safe_browsing/dmg/generate_test_data.sh to not silently
fail.

generate_test_data.sh uses `hdiutil create` and `hdiutil convert`. The former
can overwrite an existing output file, but the latter cannot. This led to the
following error:

  hdiutil: convert failed - File exists

But this message was getting swallowed because the script 1) did not do `set -e`
to stop on errors, and 2) redirect all output to /dev/null. This also fixes both
of those issues.

BUG=696529
R=thakis@chromium.org
==========

to

==========
Fix chrome/test/data/safe_browsing/dmg/generate_test_data.sh to not silently
fail.

generate_test_data.sh uses `hdiutil create` and `hdiutil convert`. The former
can overwrite an existing output file, but the latter cannot. This led to the
following error:

  hdiutil: convert failed - File exists

But this message was getting swallowed because the script 1) did not do `set -e`
to stop on errors, and 2) redirect all output to /dev/null. This also fixes both
of those issues.

BUG=696529
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2748453002
Cr-Commit-Position: refs/heads/master@{#456141}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fe29f761d6791d746bd7e058d6f...
==========

[commit-bot: I haz the power, 2017-03-10 20:00:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fe29f761d6791d746bd7e058d6f...