Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/test/data/safe_browsing/dmg/make_hfs.sh

Issue 2748453002: Fix chrome/test/data/safe_browsing/dmg/generate_test_data.sh to not silently fail. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/safe_browsing/dmg/generate_test_data.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/safe_browsing/dmg/make_hfs.sh
diff --git a/chrome/test/data/safe_browsing/dmg/make_hfs.sh b/chrome/test/data/safe_browsing/dmg/make_hfs.sh
index df08184584fc5cacaca9752b7a50ac3b85ccf1fc..bc478c4ecf8568568ad73220eeee914db415bc75 100755
--- a/chrome/test/data/safe_browsing/dmg/make_hfs.sh
+++ b/chrome/test/data/safe_browsing/dmg/make_hfs.sh
@@ -7,7 +7,7 @@
# This script is used to generate an HFS file system with several types of
# files of different sizes.
-set -e
+set -eu
FILESYSTEM_TYPE="$1"
RAMDISK_SIZE="$2"
@@ -46,7 +46,7 @@ pushd third
pushd fourth
pushd fifth
-dd if=/dev/random of=random bs=1 count=768
+dd if=/dev/random of=random bs=1 count=768 &> /dev/null
popd # fourth
@@ -75,5 +75,5 @@ popd # Original PWD
# Unmount the volume, copy the raw device to a file, and then destroy it.
diskutil unmount ${RAMDISK_VOLUME}
-dd if=${RAMDISK_VOLUME} of="${OUT_FILE}"
+dd if=${RAMDISK_VOLUME} of="${OUT_FILE}" &> /dev/null
diskutil eject ${RAMDISK_VOLUME}
« no previous file with comments | « chrome/test/data/safe_browsing/dmg/generate_test_data.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698