Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2748383002: [instrumentation] Generate instrumentation probes with jinja2 (Closed)
Patch Set: addressing comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index 42eec860787abce46401365905dff0598e40919f..1a179aafe75c55fcf37911464b59a2181d954d99 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -92,24 +92,29 @@ blink_core_sources("inspector") {
]
}
-action("instrumentation_sources") {
+# instrumentation probes -------------------------------------------------------
+
+action("instrumentation_probes") {
visibility = [ ":*" ]
- script = "CodeGeneratorInstrumentation.py"
+ script = "InstrumentingProbesCodeGenerator.py"
inputs = [
# Input file for the script.
- "InspectorInstrumentation.idl",
+ "InstrumentingProbes.idl",
+ "InstrumentingProbesImpl_cpp.template",
+ "InstrumentingProbesImpl_h.template",
+ "InstrumentingAgents_h.template",
]
outputs = [
"$blink_core_output_dir/InspectorInstrumentationInl.h",
"$blink_core_output_dir/InspectorOverridesInl.h",
+ "$blink_core_output_dir/InstrumentingProbesImpl.cpp",
"$blink_core_output_dir/InstrumentingAgents.h",
- "$blink_core_output_dir/InspectorInstrumentationImpl.cpp",
]
args = [
- rebase_path("InspectorInstrumentation.idl", root_build_dir),
+ rebase_path("InstrumentingProbes.idl", root_build_dir),
"--output_dir",
rebase_path(blink_core_output_dir, root_build_dir),
]
@@ -194,7 +199,7 @@ inspector_protocol_generate("protocol_sources") {
# Compiles the sources generated above.
source_set("generated") {
sources = get_target_outputs(":protocol_sources") +
- get_target_outputs(":instrumentation_sources")
+ get_target_outputs(":instrumentation_probes")
configs -= core_config_remove
configs += core_config_add + [
@@ -207,7 +212,7 @@ source_set("generated") {
}
deps = [
- ":instrumentation_sources",
+ ":instrumentation_probes",
":protocol_sources",
"//skia",
"//third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated",
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698