Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2748343002: Reland of un compositing/ and paint/ for disable-spinvalidation (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of un compositing/ and paint/ for disable-spinvalidation (patchset #1 id:1 of https://codereview.chromium.org/2756433002/ ) Reason for revert: The failing test just needs a rebaseline, or it's flaky unrelated to the CL. Original issue's description: > Revert of Run compositing/ and paint/ for disable-spinvalidation (patchset #3 id:40001 of https://codereview.chromium.org/2750943002/ ) > > Reason for revert: > Caused failure on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9279 > > 20:01:44.340 2964 [657/51934] virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html failed unexpectedly (image diff) > 20:01:44.334 1652 worker/3 virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html failed: > 20:01:44.334 1652 worker/3 image diff > > > Original issue's description: > > Run compositing/ and paint/ for disable-spinvalidation > > > > This is to increase test coverage for disable-spinvalidation to reduce > > risk of breaking it. > > > > Total number of virtual/disable-spinvalidation tests is 1676 > > (was 913 previously). > > > > Review-Url: https://codereview.chromium.org/2750943002 > > Cr-Commit-Position: refs/heads/master@{#456939} > > Committed: https://chromium.googlesource.com/chromium/src/+/becaabeceb9fbb249e4c7a72b85f4f20cd826f95 > > TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2756433002 > Cr-Commit-Position: refs/heads/master@{#457052} > Committed: https://chromium.googlesource.com/chromium/src/+/571b63355d05baec5383a3a297d1b72315296f4a TBR=chrishtr@chromium.org,pdr@chromium.org,grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2748343002 Cr-Commit-Position: refs/heads/master@{#457096} Committed: https://chromium.googlesource.com/chromium/src/+/c9af99aa1d6d8caec1992e0f62f37e3cf54296ac

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 7 chunks +18 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +6 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-skew-matrix-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-with-squashing-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/scrollbars/custom-composited-different-track-parts-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/squashing/squash-transform-repainting-child-expected.txt View 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt View 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/README.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Xianzhu
Created Reland of un compositing/ and paint/ for disable-spinvalidation
3 years, 9 months ago (2017-03-15 15:52:12 UTC) #1
Xianzhu
Rebaselining of the virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html produced no result, indicating that the test is flaky. Marked it ...
3 years, 9 months ago (2017-03-15 15:59:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748343002/280001
3 years, 9 months ago (2017-03-15 16:00:53 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 16:04:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/c9af99aa1d6d8caec1992e0f62f3...

Powered by Google App Engine
This is Rietveld 408576698