Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2750943002: Run compositing/ and paint/ for disable-spinvalidation (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
chrishtr, pdr.
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run compositing/ and paint/ for disable-spinvalidation This is to increase test coverage for disable-spinvalidation to reduce risk of breaking it. Total number of virtual/disable-spinvalidation tests is 1676 (was 913 previously). Review-Url: https://codereview.chromium.org/2750943002 Cr-Commit-Position: refs/heads/master@{#456939} Committed: https://chromium.googlesource.com/chromium/src/+/becaabeceb9fbb249e4c7a72b85f4f20cd826f95

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Rebaseline-cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 8 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +6 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-skew-matrix-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-with-squashing-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/search-field-cancel-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/scrollbars/custom-composited-different-track-parts-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/README.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/squashing/squash-transform-repainting-child-expected.txt View 1 2 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt View 1 2 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/README.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/README.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (17 generated)
Xianzhu
3 years, 9 months ago (2017-03-14 20:50:22 UTC) #3
pdr.
On 2017/03/14 at 20:50:22, wangxianzhu wrote: > LGTM
3 years, 9 months ago (2017-03-14 21:05:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750943002/40001
3 years, 9 months ago (2017-03-15 01:26:20 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/becaabeceb9fbb249e4c7a72b85f4f20cd826f95
3 years, 9 months ago (2017-03-15 01:35:10 UTC) #21
Henrik Grunell
3 years, 9 months ago (2017-03-15 11:13:02 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2756433002/ by grunell@chromium.org.

The reason for reverting is: Caused failure on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

20:01:44.340 2964 [657/51934]
virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html
failed unexpectedly (image diff)
20:01:44.334 1652 worker/3
virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html
failed:
20:01:44.334 1652 worker/3  image diff
.

Powered by Google App Engine
This is Rietveld 408576698