Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2748133006: Do not delete notification ids unknown by the display service (Closed)

Created:
3 years, 9 months ago by Miguel Garcia
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Do not delete notification ids unknown by the display service This is a temporary set of reverts so they can go into M58. Revert "clean up LayoutTestNotificationManager overrides" This reverts commit 0e9764ee9211235cb379f45df8bf983af2b0b0aa. Revert "Test the platform notification context synchronize operation" This reverts commit f3f824cd5032eac3c694bd9b7a5c05a2e45ebc5c. Revert "Fix a couple of notification TODOs" This reverts commit e50bfa204461eba626ab5891799669f9bf8231be. BUG=571056, 700343 Review-Url: https://codereview.chromium.org/2739943006 Cr-Commit-Position: refs/heads/master@{#456041} (cherry picked from commit 865a357dda206267aafd20d23382b452cec8c084) Review-Url: https://codereview.chromium.org/2748133006 . Cr-Commit-Position: refs/branch-heads/3029@{#218} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b3c1d9d6170108539e5ba8662692e0478366daac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -94 lines) Patch
M content/browser/notifications/notification_database.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 3 chunks +0 lines, -81 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 2 chunks +79 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 chunk +174 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Miguel Garcia
3 years, 9 months ago (2017-03-15 21:52:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3c1d9d6170108539e5ba8662692e0478366daac.

Powered by Google App Engine
This is Rietveld 408576698