Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2739943006: Do not delete notification ids unknown by the display service (Closed)

Created:
3 years, 9 months ago by Miguel Garcia
Modified:
3 years, 9 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, awdf+watch_chromium.org, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not delete notification ids unknown by the display service This is a temporary set of reverts so they can go into M58. Revert "clean up LayoutTestNotificationManager overrides" This reverts commit 0e9764ee9211235cb379f45df8bf983af2b0b0aa. Revert "Test the platform notification context synchronize operation" This reverts commit f3f824cd5032eac3c694bd9b7a5c05a2e45ebc5c. Revert "Fix a couple of notification TODOs" This reverts commit e50bfa204461eba626ab5891799669f9bf8231be. BUG=571056, 700343 Review-Url: https://codereview.chromium.org/2739943006 Cr-Commit-Position: refs/heads/master@{#456041} Committed: https://chromium.googlesource.com/chromium/src/+/865a357dda206267aafd20d23382b452cec8c084

Patch Set 1 #

Patch Set 2 : keep conent/test/* files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -94 lines) Patch
M content/browser/notifications/notification_database.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 3 chunks +0 lines, -81 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 2 chunks +79 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 chunk +174 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Miguel Garcia
This is just a temporary patch so we can merge it into M58 I will ...
3 years, 9 months ago (2017-03-09 19:04:23 UTC) #4
Peter Beverloo
lgtm, but please leave the //chrome/test/ stuff alone. We don't ship it and it avoids ...
3 years, 9 months ago (2017-03-09 21:27:17 UTC) #7
Peter Beverloo
On 2017/03/09 21:27:17, Peter Beverloo wrote: > lgtm, but please leave the //chrome/test/ stuff alone. ...
3 years, 9 months ago (2017-03-09 21:27:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739943006/20001
3 years, 9 months ago (2017-03-10 11:38:00 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 11:42:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/865a357dda206267aafd20d23382...

Powered by Google App Engine
This is Rietveld 408576698