Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2748103013: Adjust elision of omnibox keyword search label. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Adjust elision of omnibox keyword search label. The search label will be limited to 50% of the omnibox width. The minimum width will be just the search icon, although it's unlikely that the omnibox will ever be that small on most platforms. See bug for extended discussion. BUG=694152 Review-Url: https://codereview.chromium.org/2731113002 Cr-Commit-Position: refs/heads/master@{#457255} (cherry picked from commit cdedb4788d9ead1bdb685cfa1e765ae15fcd7ea9) Review-Url: https://codereview.chromium.org/2748103013 . Cr-Commit-Position: refs/branch-heads/3029@{#262} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/fc437f4143b27bb3fb511a7d20d88188c5fd1f57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -80 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm View 2 chunks +24 lines, -3 lines 0 comments Download
D chrome/browser/ui/location_bar/location_bar_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/ui/location_bar/location_bar_util.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 4 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
3 years, 9 months ago (2017-03-17 14:49:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc437f4143b27bb3fb511a7d20d88188c5fd1f57.

Powered by Google App Engine
This is Rietveld 408576698