Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: chrome/browser/ui/views/location_bar/selected_keyword_view.cc

Issue 2748103013: Adjust elision of omnibox keyword search label. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h" 5 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/search_engines/template_url_service_factory.h" 9 #include "chrome/browser/search_engines/template_url_service_factory.h"
10 #include "chrome/browser/ui/location_bar/location_bar_util.h"
11 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 10 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
12 #include "chrome/grit/generated_resources.h" 11 #include "chrome/grit/generated_resources.h"
13 #include "components/omnibox/browser/vector_icons.h" 12 #include "components/omnibox/browser/vector_icons.h"
14 #include "components/search_engines/template_url_service.h" 13 #include "components/search_engines/template_url_service.h"
15 #include "ui/base/l10n/l10n_util.h" 14 #include "ui/base/l10n/l10n_util.h"
16 #include "ui/base/theme_provider.h" 15 #include "ui/base/theme_provider.h"
17 #include "ui/gfx/color_palette.h" 16 #include "ui/gfx/color_palette.h"
18 #include "ui/gfx/color_utils.h" 17 #include "ui/gfx/color_utils.h"
19 #include "ui/gfx/paint_vector_icon.h" 18 #include "ui/gfx/paint_vector_icon.h"
20 #include "ui/gfx/vector_icons_public.h" 19 #include "ui/gfx/vector_icons_public.h"
21 #include "ui/native_theme/native_theme.h" 20 #include "ui/native_theme/native_theme.h"
22 21
23 SelectedKeywordView::SelectedKeywordView(const gfx::FontList& font_list, 22 SelectedKeywordView::SelectedKeywordView(const gfx::FontList& font_list,
24 Profile* profile) 23 Profile* profile)
25 : IconLabelBubbleView(font_list, false), profile_(profile) { 24 : IconLabelBubbleView(font_list, false), profile_(profile) {
26 full_label_.SetFontList(font_list); 25 full_label_.SetFontList(font_list);
27 full_label_.SetVisible(false); 26 full_label_.SetVisible(false);
28 partial_label_.SetFontList(font_list); 27 partial_label_.SetFontList(font_list);
29 partial_label_.SetVisible(false); 28 partial_label_.SetVisible(false);
29 label()->SetElideBehavior(gfx::FADE_TAIL);
30 } 30 }
31 31
32 SelectedKeywordView::~SelectedKeywordView() { 32 SelectedKeywordView::~SelectedKeywordView() {
33 } 33 }
34 34
35 void SelectedKeywordView::ResetImage() { 35 void SelectedKeywordView::ResetImage() {
36 SetImage(gfx::CreateVectorIcon(omnibox::kSearchIcon, 36 SetImage(gfx::CreateVectorIcon(omnibox::kSearchIcon,
37 LocationBarView::kIconWidth, GetTextColor())); 37 LocationBarView::kIconWidth, GetTextColor()));
38 } 38 }
39 39
40 SkColor SelectedKeywordView::GetTextColor() const { 40 SkColor SelectedKeywordView::GetTextColor() const {
41 return GetNativeTheme()->GetSystemColor( 41 return GetNativeTheme()->GetSystemColor(
42 color_utils::IsDark(GetParentBackgroundColor()) 42 color_utils::IsDark(GetParentBackgroundColor())
43 ? ui::NativeTheme::kColorId_TextfieldDefaultColor 43 ? ui::NativeTheme::kColorId_TextfieldDefaultColor
44 : ui::NativeTheme::kColorId_LinkEnabled); 44 : ui::NativeTheme::kColorId_LinkEnabled);
45 } 45 }
46 46
47 gfx::Size SelectedKeywordView::GetPreferredSize() const { 47 gfx::Size SelectedKeywordView::GetPreferredSize() const {
48 // Height will be ignored by the LocationBarView. 48 // Height will be ignored by the LocationBarView.
49 return GetSizeForLabelWidth(full_label_.GetPreferredSize().width()); 49 return GetSizeForLabelWidth(full_label_.GetPreferredSize().width());
50 } 50 }
51 51
52 gfx::Size SelectedKeywordView::GetMinimumSize() const { 52 gfx::Size SelectedKeywordView::GetMinimumSize() const {
53 // Height will be ignored by the LocationBarView. 53 // Height will be ignored by the LocationBarView.
54 return GetSizeForLabelWidth(partial_label_.GetMinimumSize().width()); 54 return GetSizeForLabelWidth(0);
55 } 55 }
56 56
57 void SelectedKeywordView::Layout() { 57 void SelectedKeywordView::Layout() {
58 SetLabel(((width() == GetPreferredSize().width()) ? 58 // Keep showing the full label as long as there's more than enough width for
59 full_label_ : partial_label_).text()); 59 // the partial label. Otherwise there will be empty space displayed next to
60 // the partial label.
61 bool use_full_label =
62 width() >
63 GetSizeForLabelWidth(partial_label_.GetPreferredSize().width()).width();
64 SetLabel(use_full_label ? full_label_.text() : partial_label_.text());
65
60 IconLabelBubbleView::Layout(); 66 IconLabelBubbleView::Layout();
61 } 67 }
62 68
63 void SelectedKeywordView::SetKeyword(const base::string16& keyword) { 69 void SelectedKeywordView::SetKeyword(const base::string16& keyword) {
64 keyword_ = keyword; 70 keyword_ = keyword;
65 if (keyword.empty()) 71 if (keyword.empty())
66 return; 72 return;
67 DCHECK(profile_); 73 DCHECK(profile_);
68 TemplateURLService* model = 74 TemplateURLService* model =
69 TemplateURLServiceFactory::GetForProfile(profile_); 75 TemplateURLServiceFactory::GetForProfile(profile_);
70 if (!model) 76 if (!model)
71 return; 77 return;
72 78
73 bool is_extension_keyword; 79 bool is_extension_keyword;
74 const base::string16 short_name = 80 const base::string16 short_name =
75 model->GetKeywordShortName(keyword, &is_extension_keyword); 81 model->GetKeywordShortName(keyword, &is_extension_keyword);
76 const base::string16 full_name = 82 const base::string16 full_name =
77 is_extension_keyword 83 is_extension_keyword
78 ? short_name 84 ? short_name
79 : l10n_util::GetStringFUTF16(IDS_OMNIBOX_KEYWORD_TEXT_MD, short_name); 85 : l10n_util::GetStringFUTF16(IDS_OMNIBOX_KEYWORD_TEXT_MD, short_name);
80 full_label_.SetText(full_name); 86 full_label_.SetText(full_name);
81 87
82 const base::string16 min_string( 88 partial_label_.SetText(short_name);
83 location_bar_util::CalculateMinString(short_name));
84 const base::string16 partial_name =
85 is_extension_keyword
86 ? min_string
87 : l10n_util::GetStringFUTF16(IDS_OMNIBOX_KEYWORD_TEXT_MD, min_string);
88 partial_label_.SetText(min_string.empty() ?
89 full_label_.text() : partial_name);
90 89
91 // Update the label now so ShouldShowLabel() works correctly when the parent 90 // Update the label now so ShouldShowLabel() works correctly when the parent
92 // class is calculating the preferred size. It will be updated again in 91 // class is calculating the preferred size. It will be updated again in
93 // Layout(), taking into account how much space has actually been allotted. 92 // Layout(), taking into account how much space has actually been allotted.
94 SetLabel(full_name); 93 SetLabel(full_name);
95 } 94 }
96 95
97 const char* SelectedKeywordView::GetClassName() const { 96 const char* SelectedKeywordView::GetClassName() const {
98 return "SelectedKeywordView"; 97 return "SelectedKeywordView";
99 } 98 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698