Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2748103006:
[Typed OM] Remove MutableStylePropertyMap - it seems unnecessary. (Closed)
|
Created:
3 years, 9 months ago by meade_UTC10 Modified:
3 years, 8 months ago CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Typed OM] Remove MutableStylePropertyMap
This is just a random cleanup of unnecessary code. It seems unnecessary
now that we have StylePropertyMapReadonly and StylePropertyMap.
BUG=545318
Review-Url: https://codereview.chromium.org/2748103006
Cr-Commit-Position: refs/heads/master@{#459997}
Committed: https://chromium.googlesource.com/chromium/src/+/f2e73a29defb5173967c94a19606bc302468e61e
Patch Set 1 #Patch Set 2 : Fix other references #Patch Set 3 : Revert unrelated files #
Dependent Patchsets: Messages
Total messages: 34 (22 generated)
Description was changed from ========== [Typed OM] Remove MutableStylePropertyMap - it seems unnecessary. This is just a random cleanup of unnecessary code. BUG=545318 ========== to ========== [Typed OM] Remove MutableStylePropertyMap This is just a random cleanup of unnecessary code. It seems unnecessary now that we have StylePropertyMapReadonly and StylePropertyMap. BUG=545318 ==========
meade@chromium.org changed reviewers: + shend@chromium.org
The CQ bit was checked by meade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
On 2017/03/15 at 03:24:13, meade wrote: > lgtm
The CQ bit was checked by meade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by meade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org Link to the patchset: https://codereview.chromium.org/2748103006/#ps40001 (title: "Revert unrelated files")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
meade@chromium.org changed reviewers: + nainar@chromium.org
The CQ bit was checked by meade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/15 at 05:52:08, meade wrote: > rs lgtm
The CQ bit was unchecked by meade@chromium.org
The CQ bit was checked by meade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by meade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by meade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490660317862180,
"parent_rev": "296ebdae36af19a38f2356b28c70f27fa71a89ec", "commit_rev":
"f2e73a29defb5173967c94a19606bc302468e61e"}
Message was sent while issue was closed.
Description was changed from ========== [Typed OM] Remove MutableStylePropertyMap This is just a random cleanup of unnecessary code. It seems unnecessary now that we have StylePropertyMapReadonly and StylePropertyMap. BUG=545318 ========== to ========== [Typed OM] Remove MutableStylePropertyMap This is just a random cleanup of unnecessary code. It seems unnecessary now that we have StylePropertyMapReadonly and StylePropertyMap. BUG=545318 Review-Url: https://codereview.chromium.org/2748103006 Cr-Commit-Position: refs/heads/master@{#459997} Committed: https://chromium.googlesource.com/chromium/src/+/f2e73a29defb5173967c94a19606... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f2e73a29defb5173967c94a19606... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
