Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2726733004: [Experimental] Implement some part of custom properties in style maps (Closed)

Created:
3 years, 9 months ago by meade_UTC10
Modified:
3 years, 7 months ago
Reviewers:
CC:
rjwright
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Experimental] Implement some part of custom properties in style maps BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove AtomicString fiddling #

Patch Set 3 : Remove spurious thing #

Total comments: 1

Patch Set 4 : Merge branch 'remove-random' into computedstyle #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -133 lines) Patch
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h View 1 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp View 1 2 2 chunks +46 lines, -116 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 5 (1 generated)
meade_UTC10
https://codereview.chromium.org/2726733004/diff/1/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp (right): https://codereview.chromium.org/2726733004/diff/1/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp#newcode29 third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:29: builder.append(vector[i]->cssText()); Just landed the CL to do this properly: ...
3 years, 9 months ago (2017-03-02 00:13:51 UTC) #1
meade_UTC10
https://codereview.chromium.org/2726733004/diff/1/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h (right): https://codereview.chromium.org/2726733004/diff/1/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h#newcode55 third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:55: PseudoId m_pseudoId; I think these members should be private; ...
3 years, 9 months ago (2017-03-02 00:16:59 UTC) #2
meade_UTC10
I updated this, but the dependent CL is now showing in the diff. It's on ...
3 years, 9 months ago (2017-03-15 06:21:01 UTC) #3
meade_UTC10
3 years, 9 months ago (2017-03-15 06:32:35 UTC) #4
Ah, fixed the diff issue, and duplicated the comment onto the last patchset.

https://codereview.chromium.org/2726733004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2726733004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:81: //
TODO(meade): Do need to update style?
Need to make a helper function for the style updating thing as above in
getAllInternal(CSSPropertyID).

Powered by Google App Engine
This is Rietveld 408576698