Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2748083006: Minor revision related to SpellChecker::advanceToNextMisspelling() (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor revision related to SpellChecker::advanceToNextMisspelling() This patch removes an unused default parameter value from the above function, and make it called directly in unit test SpellCheckerTest.AdvaneToNextMisspellingWithEmptyInputNoCrash. R=yosin@chromium.org BUG=n/a TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2748083006 Cr-Commit-Position: refs/heads/master@{#458343} Committed: https://chromium.googlesource.com/chromium/src/+/ff43696e2b251c3918d432c04aad41ff9e1a9a64

Patch Set 1 #

Patch Set 2 : Wed Mar 15 11:19:30 PDT 2017 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL. Forgot to send it yesterday...
3 years, 9 months ago (2017-03-16 17:50:42 UTC) #7
Xiaocheng
+tkent, yoichio
3 years, 9 months ago (2017-03-21 03:50:06 UTC) #9
yosin_UTC9
lgtm https://codereview.chromium.org/2748083006/diff/20001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h (right): https://codereview.chromium.org/2748083006/diff/20001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h#newcode68 third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h:68: void advanceToNextMisspelling(bool startBeforeSelection); Thanks for removing default parameter! ...
3 years, 9 months ago (2017-03-21 05:31:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748083006/20001
3 years, 9 months ago (2017-03-21 05:32:20 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 07:36:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff43696e2b251c3918d432c04aad...

Powered by Google App Engine
This is Rietveld 408576698