third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp - Issue 2748083006: Minor revision related to SpellChecker::advanceToNextMisspelling()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

Issue 2748083006: Minor revision related to SpellChecker::advanceToNextMisspelling() (Closed)

Patch Set: Wed Mar 15 11:19:30 PDT 2017 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('K') | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

index 1b6fbca103e33089c6677e7eeecb86c8c956ebde..a4f6a1378bbf1cf5fb78c1ea1164752e98fc6b6a 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

@@ -35,9 +35,8 @@ TEST_F(SpellCheckerTest, AdvanceToNextMisspellingWithEmptyInputNoCrash) {

updateAllLifecyclePhases();

Element* input = document().querySelector("input");

input->focus();

- // Do not crash in AdvanceToNextMisspelling command.

- EXPECT_TRUE(

- document().frame()->editor().executeCommand("AdvanceToNextMisspelling"));

+ // Do not crash in advanceToNextMisspelling.

+ document().frame()->spellChecker().advanceToNextMisspelling(false);

}

// Regression test for crbug.com/701309

« third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('K') | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('k') | no next file » | no next file with comments »