Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748073002: Revert "VM: Simplify lowering of is-tests." (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Simplify lowering of is-tests." This reverts commit 066123e037b530ae2c073b61601d518ed70d6efa. Reason for revert: vm-kernel-* is broken because kernel_to_il.cc was not updated in sync with flow_graph_builder.cc. TBR=fschneider@google.com, rmacnak@google.com, Committed: https://github.com/dart-lang/sdk/commit/d44fec08b06198341a2110a54d2b9c8fb131def9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -63 lines) Patch
M runtime/lib/object.cc View 3 chunks +62 lines, -2 lines 0 comments Download
M runtime/lib/object_patch.dart View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.cc View 5 chunks +45 lines, -13 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/constant_propagator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/constants_dbc.h View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +38 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 4 chunks +40 lines, -10 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Vyacheslav Egorov (Google)
TBR
3 years, 9 months ago (2017-03-14 11:27:04 UTC) #3
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-03-14 11:27:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d44fec08b06198341a2110a54d2b9c8fb131def9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698