runtime/vm/intermediate_language_x64.cc - Issue 2748073002: Revert "VM: Simplify lowering of is-tests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 2748073002: Revert "VM: Simplify lowering of is-tests." (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_x64.cc

diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc

index ce58edc5272d8bdeddb9d31e474bcc73dda5133b..a670cd08e560bb0fbeea6cb2437d3f0c0f1f948d 100644

--- a/runtime/vm/intermediate_language_x64.cc

+++ b/runtime/vm/intermediate_language_x64.cc

@@ -2045,7 +2045,8 @@ void InstanceOfInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

ASSERT(locs()->in(0).reg() == RAX); // Value.

ASSERT(locs()->in(1).reg() == RDX); // Instantiator type arguments.

- compiler->GenerateInstanceOf(token_pos(), deopt_id(), type(), locs());

+ compiler->GenerateInstanceOf(token_pos(), deopt_id(), type(), negate_result(),

+ locs());

ASSERT(locs()->out(0).reg() == RAX);

}

« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/jit_optimizer.cc » ('j') | no next file with comments »