Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2618)

Unified Diff: runtime/vm/simulator_dbc.cc

Issue 2748073002: Revert "VM: Simplify lowering of is-tests." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/simulator_dbc.cc
diff --git a/runtime/vm/simulator_dbc.cc b/runtime/vm/simulator_dbc.cc
index e0457de4433834ecb844eaaef15c95b4fc7f310a..d16a5a375869ea3c06faeb2d7826d0b627feec63 100644
--- a/runtime/vm/simulator_dbc.cc
+++ b/runtime/vm/simulator_dbc.cc
@@ -2924,7 +2924,7 @@ RawObject* Simulator::Call(const Code& code,
}
{
- BYTECODE(InstanceOf, 0); // Stack: instance, type args, type, cache
+ BYTECODE(InstanceOf, A); // Stack: instance, type args, type, cache
RawInstance* instance = static_cast<RawInstance*>(SP[-3]);
RawTypeArguments* instantiator_type_arguments =
static_cast<RawTypeArguments*>(SP[-2]);
@@ -2984,6 +2984,9 @@ RawObject* Simulator::Call(const Code& code,
InstanceOfOk:
SP -= 3;
+ if (rA) { // Negate result.
+ SP[0] = (SP[0] == true_value) ? false_value : true_value;
+ }
DISPATCH();
}
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698