Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2748033002: Revert of Moving previews code from components/ to chrome/ (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
RyanSturm, tbansal1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving previews code from components/ to chrome/ (patchset #4 id:60001 of https://codereview.chromium.org/2739033005/ ) Reason for revert: Builders this step failed on: Linux Tests [17 since first detection] 1 test failed: LoadAndLaunchExtensionBrowserTest.LoadAndLaunchExtension Since: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/53070 Original issue's description: > Moving previews code from components/ to chrome/ > > Allows support for looking in other components or chrome code to verify > if a preview is enabled and check the previews version. The layering > dynamic is that components such as d_r_p will depend on previews/ and > not the other way around, so these methods should be moved to chrome/ > and relevant information should be injected. > > BUG=700459 > > Review-Url: https://codereview.chromium.org/2739033005 > Cr-Commit-Position: refs/heads/master@{#456511} > Committed: https://chromium.googlesource.com/chromium/src/+/e69df7ab2555ce8874972c419b13add8e0ec0c32 TBR=tbansal@chromium.org,ryansturm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700459 Review-Url: https://codereview.chromium.org/2748033002 Cr-Commit-Position: refs/heads/master@{#456640} Committed: https://chromium.googlesource.com/chromium/src/+/079434a138a811058137ee9dfb289e6155101cb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -199 lines) Patch
M chrome/browser/previews/previews_service.cc View 2 chunks +1 line, -51 lines 0 comments Download
M components/previews/core/previews_experiments.h View 2 chunks +11 lines, -7 lines 0 comments Download
M components/previews/core/previews_experiments.cc View 2 chunks +41 lines, -13 lines 0 comments Download
M components/previews/core/previews_experiments_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/previews/core/previews_io_data.h View 4 chunks +1 line, -8 lines 0 comments Download
M components/previews/core/previews_io_data.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M components/previews/core/previews_io_data_unittest.cc View 4 chunks +15 lines, -28 lines 0 comments Download
M components/previews/core/previews_opt_out_store_sql.h View 2 chunks +1 line, -5 lines 0 comments Download
M components/previews/core/previews_opt_out_store_sql.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M components/previews/core/previews_opt_out_store_sql_unittest.cc View 13 chunks +56 lines, -53 lines 0 comments Download
M components/previews/core/previews_ui_service.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/previews/core/previews_ui_service.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/previews/core/previews_ui_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yoichio
Created Revert of Moving previews code from components/ to chrome/
3 years, 9 months ago (2017-03-14 06:44:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748033002/1
3 years, 9 months ago (2017-03-14 06:44:57 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 06:46:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/079434a138a811058137ee9dfb28...

Powered by Google App Engine
This is Rietveld 408576698