Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: components/previews/core/previews_experiments.cc

Issue 2748033002: Revert of Moving previews code from components/ to chrome/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/previews/core/previews_experiments.cc
diff --git a/components/previews/core/previews_experiments.cc b/components/previews/core/previews_experiments.cc
index 7b6d539b578f833ba15ab75f23b632a8cc4bc877..77b973a2da62fdec35f3d677bf22d50c40105690 100644
--- a/components/previews/core/previews_experiments.cc
+++ b/components/previews/core/previews_experiments.cc
@@ -189,19 +189,6 @@
return effective_connection_type;
}
-bool IsOfflinePreviewsEnabled() {
- // Check if "show_offline_pages" is set to "true".
- return ClientSidePreviewsParamValue(kOfflinePagesSlowNetwork) ==
- kExperimentEnabled;
-}
-
-int OfflinePreviewsVersion() {
- int version;
- if (!base::StringToInt(ClientSidePreviewsParamValue(kVersion), &version))
- version = 0;
- return version;
-}
-
} // namespace params
bool IsIncludedInClientSidePreviewsExperimentsFieldTrial() {
@@ -213,6 +200,47 @@
kEnabled, base::CompareCase::SENSITIVE);
}
+bool IsPreviewsTypeEnabled(PreviewsType type) {
+ switch (type) {
+ case PreviewsType::OFFLINE:
+ return ClientSidePreviewsParamValue(kOfflinePagesSlowNetwork) ==
+ kExperimentEnabled;
+ default:
+ NOTREACHED();
+ return false;
+ }
+}
+
+int GetPreviewsTypeVersion(PreviewsType type) {
+ int version = 0; // default
+ switch (type) {
+ case PreviewsType::OFFLINE:
+ base::StringToInt(ClientSidePreviewsParamValue(kVersion), &version);
+ return version;
+ // List remaining enum cases vs. default to catch when new one is added.
+ case PreviewsType::NONE:
+ break;
+ case PreviewsType::LAST:
+ break;
+ }
+ NOTREACHED();
+ return -1;
+}
+
+std::unique_ptr<PreviewsTypeList> GetEnabledPreviews() {
+ std::unique_ptr<PreviewsTypeList> enabled_previews(new PreviewsTypeList());
+
+ // Loop across all previews types (relies on sequential enum values).
+ for (int i = static_cast<int>(PreviewsType::NONE) + 1;
+ i < static_cast<int>(PreviewsType::LAST); ++i) {
+ PreviewsType type = static_cast<PreviewsType>(i);
+ if (IsPreviewsTypeEnabled(type)) {
+ enabled_previews->push_back({type, GetPreviewsTypeVersion(type)});
+ }
+ }
+ return enabled_previews;
+}
+
bool EnableOfflinePreviewsForTesting() {
std::map<std::string, std::string> params;
params[kOfflinePagesSlowNetwork] = kExperimentEnabled;
« no previous file with comments | « components/previews/core/previews_experiments.h ('k') | components/previews/core/previews_experiments_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698