Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2748023004: Fix unsupported audio channel layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by tguilbert
Modified:
4 months, 1 week ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unsupported audio channel layout We currently do not check the returned channel layout when converting Ffmpeg to chrome channel layouts. This means that we still try to create audio buffers whenever we have an unsupported channel layout. This causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor. This CL fixes the issue by erroring out early rather than trying to create an invalid AudioBuffer. BUG=699373 TEST=manually checked it didn't crash anymore Review-Url: https://codereview.chromium.org/2748023004 Cr-Commit-Position: refs/heads/master@{#457302} Committed: https://chromium.googlesource.com/chromium/src/+/cd31831bb240ce19d3e3af6f2b95f8ad11c96e5c

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
tguilbert
PTAL, thanks!
4 months, 2 weeks ago (2017-03-15 03:28:45 UTC) #3
DaleCurtis
lgtm
4 months, 1 week ago (2017-03-15 22:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748023004/1
4 months, 1 week ago (2017-03-15 22:56:41 UTC) #6
commit-bot: I haz the power
4 months, 1 week ago (2017-03-16 01:35:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd31831bb240ce19d3e3af6f2b95...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973