Fix unsupported audio channel layout

Fix unsupported audio channel layout

We currently do not check the returned channel layout when converting
Ffmpeg to chrome channel layouts. This means that we still try to create
audio buffers whenever we have an unsupported channel layout. This
causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.

This CL fixes the issue by erroring out early rather than trying to
create an invalid AudioBuffer.

BUG=699373
TEST=manually checked it didn't crash anymore

Review-Url: https://codereview.chromium.org/2748023004
Cr-Commit-Position: refs/heads/master@{#457302}
Committed: https://chromium.googlesource.com/chromium/src/+/cd31831bb240ce19d3e3af6f2b95f8ad11c96e5c

[tguilbert, 2017-03-15 03:27:33]

Description was changed from

==========
Fix unsupported audio channel layout

We currently do not check the returned channel layout when converting
Ffmpeg to chrome channel layouts. This means that we still try to create
audio buffers whenever we have an unsupported channel layout. This
causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.

BUG=699373
TEST=manually checked it didn't crash anymore
==========

to

==========
Fix unsupported audio channel layout

We currently do not check the returned channel layout when converting
Ffmpeg to chrome channel layouts. This means that we still try to create
audio buffers whenever we have an unsupported channel layout. This
causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.

This CL fixes the issue by erroring out early rather than trying to
create an invalid AudioBuffer.

BUG=699373
TEST=manually checked it didn't crash anymore
==========

[tguilbert, 2017-03-15 03:28:44]

tguilbert@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[tguilbert, 2017-03-15 03:28:45]

PTAL, thanks!

[DaleCurtis, 2017-03-15 22:51:29]

lgtm

[tguilbert, 2017-03-15 22:56:05]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2017-03-15 22:56:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:35:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489618565783370, "parent_rev":
"1533215983ea3066ce9060cd6fdef87dc8f452ca", "commit_rev":
"cd31831bb240ce19d3e3af6f2b95f8ad11c96e5c"}

[commit-bot: I haz the power, 2017-03-16 01:35:48]

Description was changed from

==========
Fix unsupported audio channel layout

We currently do not check the returned channel layout when converting
Ffmpeg to chrome channel layouts. This means that we still try to create
audio buffers whenever we have an unsupported channel layout. This
causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.

This CL fixes the issue by erroring out early rather than trying to
create an invalid AudioBuffer.

BUG=699373
TEST=manually checked it didn't crash anymore
==========

to

==========
Fix unsupported audio channel layout

We currently do not check the returned channel layout when converting
Ffmpeg to chrome channel layouts. This means that we still try to create
audio buffers whenever we have an unsupported channel layout. This
causes some tests to crash when hitting a DCHECK in AudioBuffer's ctor.

This CL fixes the issue by erroring out early rather than trying to
create an invalid AudioBuffer.

BUG=699373
TEST=manually checked it didn't crash anymore

Review-Url: https://codereview.chromium.org/2748023004
Cr-Commit-Position: refs/heads/master@{#457302}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd31831bb240ce19d3e3af6f2b95...
==========

[commit-bot: I haz the power, 2017-03-16 01:35:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd31831bb240ce19d3e3af6f2b95...