Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2747953002: PRESUBMIT should only check line length for .html files in c/b/resources (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PRESUBMIT should only check line length for .html files in c/b/resources After crrev.com/2729403003, chrome/browser/resources/PRESUBMIT.py checks the line length of files. It was intended to only check .html files, but instead checks *all* files *iff* at least one .html file is present. BUG=701171 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2747953002 Cr-Commit-Position: refs/heads/master@{#456553} Committed: https://chromium.googlesource.com/chromium/src/+/20e1ab9bfba1edcd809ff19894b91cf9cb7fab5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
michaelpg
PTAL
3 years, 9 months ago (2017-03-13 23:31:56 UTC) #3
dschuyler
lgtm
3 years, 9 months ago (2017-03-13 23:32:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747953002/1
3 years, 9 months ago (2017-03-13 23:35:45 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:53:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20e1ab9bfba1edcd809ff19894b9...

Powered by Google App Engine
This is Rietveld 408576698