chrome/browser/resources/PRESUBMIT.py - Issue 2747953002: PRESUBMIT should only check line length for .html files in c/b/resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2747953002: PRESUBMIT should only check line length for .html files in c/b/resources (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index a1d243c5da0f5f04e9a814660eed981b927607dd..891533fe71f3fbe12ebbd2abcc06a614e5f73b69 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -92,7 +92,8 @@ def IsBoolean(new_content_lines, metric_name, input_api):

def CheckHtml(input_api, output_api):

- return input_api.canned_checks.CheckLongLines(input_api, output_api, 80)

+ return input_api.canned_checks.CheckLongLines(

+ input_api, output_api, 80, lambda x: x.LocalPath().endswith('.html'))

def RunVulcanizeTests(input_api, output_api):

« no previous file with comments | « no previous file | no next file » | no next file with comments »